-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π§βπ» Add validate-pins workflow for PRs #26996
Merged
thinkyhead
merged 10 commits into
MarlinFirmware:bugfix-2.1.x
from
sjasonsmith:PR/format_pins_action
Apr 23, 2024
Merged
π§βπ» Add validate-pins workflow for PRs #26996
thinkyhead
merged 10 commits into
MarlinFirmware:bugfix-2.1.x
from
sjasonsmith:PR/format_pins_action
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjasonsmith
changed the title
Pr/format pins action
β
Add validate-pins github workflow for PRs
Apr 22, 2024
sjasonsmith
changed the title
β
Add validate-pins github workflow for PRs
β
Add validate-pins workflow for PRs
Apr 22, 2024
sjasonsmith
force-pushed
the
PR/format_pins_action
branch
from
April 22, 2024 04:27
cadc85b
to
867bc08
Compare
sjasonsmith
changed the title
β
Add validate-pins workflow for PRs
π§βπ» Add validate-pins workflow for PRs
Apr 22, 2024
mikezs
added a commit
to mikezs/Marlin
that referenced
this pull request
Apr 26, 2024
* bugfix-2.1.x: (111 commits) [cron] Bump distribution date (2024-04-25) π©Ή IA-Creality minor cleanup π©Ή Simple IA-Creality babystep patch πΈ Fix duplicate temperature report (MarlinFirmware#26952) [cron] Bump distribution date (2024-04-24) βοΈ MPCTEMP_START => MPC_STARTED (MarlinFirmware#27002) π§ BIQU MicroProbe V2 pull-up warning (MarlinFirmware#27008) π¨ Format pins which fail validation (MarlinFirmware#27007) β CI - Validate Pins Formatting (MarlinFirmware#26996) [cron] Bump distribution date (2024-04-23) π¨ Clean up after recent PRs [cron] Bump distribution date (2024-04-22) π Fix Flags<N> data storage width (MarlinFirmware#26995) β Add additional unit tests for types.h (MarlinFirmware#26994) β Unit test improvements (MarlinFirmware#26993) π§ Add RAMPS TMC SPI pins when !TMC_USE_SW_SPI (MarlinFirmware#26960) π Fix PID upon entering PID_FUNCTIONAL_RANGE (MarlinFirmware#26926) [cron] Bump distribution date (2024-04-21) π¨Match unit test folder structure to code (MarlinFirmware#26990) β Skip compile tests when editing unit tests (MarlinFirmware#26991) ...
RPGFabi
pushed a commit
to RPGFabi/Marlin
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an automated pins file validation check will alleviate burden from reviewers, and provide immediate feedback to contributors. This runs in a parallel manner, only taking a few seconds to check all files.
This consisted of several changes:
make validate-pins
option to the Makefile, which fails ifformat-pins
makes any changes.make validate-pins
automatically on pull requests that touch pins filesDescription of output
This will always process all files, so that a complete summary of failures will be provided in the log. The log contains:
git diff
output of all modified files. Running in the workflow, this should only be the modified pins files.git status
output, providing a concise list of files which were modified.Sample of output
(Note that in this case pinsformat is actually breaking the code, that will need to be fixed before this is merged)