-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input shaping for Z axis #27073
Input shaping for Z axis #27073
Conversation
…ation for adding z axis
…TA_[X,Y,Z] which is a thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with these changes. @JonBr306 collaborated with me and I have reviewed everything and done some testing. More testing would be desirable from those with printers that will most benefit like deltas and core*z.
MarlinFirmware/Marlin#27073 Co-Authored-By: Jonathan Brazier <[email protected]>
This is great work and perfectly maintains the quirky Marlin style for the added macros. Merging shortly! |
By the way, this effect was made obvious by having high zjerk, zaccel and zhop, which I can now keep as defaults. I believe this explains the elusive and sporadic holes in some places I had given up on fixing. |
Fantastic results. |
I just realised This has improved my z-seams too! |
That sounds interesting but I don't know what you mean by z-seams. Could you elaborate? |
Oh, I wondered if that was what you meant but couldn't think why Z input shaping would help. But it's pretty obvious from that picture that the bounce is causing the narrow then wide print path. What a great additional benefit. |
Exactly. The image is not mine, I should make a print myself with and without IS z enabled. It wasn't consistently terrible because I had my z accel and jerk so low, to reduce the bouncing. |
@dbuezas is it possible to get your config files. I have a new large Delta build and I would like to try this out. |
@ant0nyk1ng: An Ultimaker 2 will have very different values than a delta. Values will also vary from identical machine to identical machine. Since this PR is merged, grab the latest Hop on our Discord server if you need further help. |
Ok cool I will... I was interested to see his "high jerk" values and you just answered the other "all three are required for deltas" but yeah I totally missed the fact he was using a Ultimaker. |
Description
Extended ZV input shaping so it can be done in the Z axis enabling certain types of kinematics (Delta, CoreXZ and CoreYZ) to use ZV input shaping now. Some cartesian machines may also benefit from this.
Requirements
Input shaping enabled.
Benefits
Z Axis can now be input shaped.
Configurations
Enable
INPUT_SHAPING_Z
Related Issues