Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stow Z-Probe blocking future status messages after stowing #27404

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

monkeydave
Copy link
Contributor

Description

When told to home using a manual z probe, (Marlin will pause and display a "Deploy Z-Probe" message, and a "Stow Z-Probe" message afterward. This is correct behavior.

What is NOT correct, is that the "Stow Z-Probe" message is then permanently displayed this is because the deploy/stow messages are set to the max alert level which is never cleared after the user presses the button to confirm probe deployed/stowed (The messages should be a high alert level as the printer is waiting for user action and that message shouldn't be overwritten by anything else).

This 1 line fix just resets the alert level after the user has stowed the probe so messages work again. There may be a better way to fix this as I don't know the code very well, but it works for me. 😄

Requirements

Requires manually deployed/stowed bed probe

Benefits

Fixes issue #27232

Configurations

A simple config that adds a LCD and bed probe
Configuration.h.zip

@thisiskeithb thisiskeithb linked an issue Sep 5, 2024 that may be closed by this pull request
1 task
@monkeydave
Copy link
Contributor Author

Just tested this code and it no longer fixes the issue.
It does work when only homing but does not work while homing during printing from the SD card as the ui.reset_status() call returns from line 1474 of marlinui.cpp instead.

@thinkyhead thinkyhead merged commit 7634ffe into MarlinFirmware:bugfix-2.1.x Sep 9, 2024
1 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] M117 doesn't work with Stowable Z-PROBE
3 participants