Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Simplify generic variants, update DFU tool #27502

Merged

Conversation

thinkyhead
Copy link
Member

  • Update to DFU tool 1.11.0 with minor patches — for better macOS compatibility (eventually). See this thread.
  • Modify "variant" scripts to point the build.variants_dir at our folder (instead of copying into the platform).
  • Rename some boards and variants to match siblings.

@thinkyhead
Copy link
Member Author

Double-checked to make sure files are indeed being included, and it all seems good. Maple can't take the same approach, but maybe it's possible to set extra environment vars or other build flags to sort out #include <...> lines within the Maple variants.

@thinkyhead thinkyhead merged commit 08717d3 into MarlinFirmware:bugfix-2.1.x Nov 2, 2024
63 checks passed
@thinkyhead thinkyhead deleted the bf2_build_updates_PR branch November 2, 2024 23:42
@vehystrix
Copy link

Since the change in generic_create_variant.py I get build errors. I get as far as this:

Linking .pio\build\MKS_E3_V2\firmware.elf
arm-none-eabi-g++: error: C:/Users/VEH/Documents/3DPrint/Printer: No such file or directory
arm-none-eabi-g++: error: upgrades/Marlin/buildroot/share/PlatformIO/variants/MARLIN_MKS_E3/ldscript.ld: No such file or directory
*** [.pio\build\MKS_E3_V2\firmware.elf] Error 1

Note that I am using the path C:\Users\VEH\Documents\3DPrint\Printer upgrades\Marlin as my marlin source path. When I remove the space in the path, the build completes as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants