Add support for high temperature thermistors #2941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first commit
Thermistor compatible with high temperatues are not accurate at low temperatures, sometimes resulting in mintemp error. # changes the configs to allow for high temperature thermistors # add pre-heating buffer time when switching heating on before taking first reading (thus avoiding mintemp errors while keeping the safety measures activated)
Also update icons/logo
Adjust mintemp to 21 for the updated thermistor table. This will avoid confusion with users reading 0°C.
Add M109 preheat gcode fix for mintemp error
Update Configuration.h
Update Marlin_main.cpp
Modified to the right values with microstep settings.
Because of a bad merge from my part, the version of temperature.cpp I was using was not the same as the one in the tag 1.0.2 which made it impossible to track change between the original file and our tweaked version. This fix should make it easier to track differences
add reset for consecutive_low_temperature_error[1] and consecutive_low_temperature_error[2]
Deleted preheating condition by mistakes from min temperature error check in last commit
- Remove changes to marlin_main.cpp and move logic previously added to temperature.h SetTargetHotend - Move preheating constant to Configuration.h and set default value to 0.
Checked and adjusted temperatures with two thermistors and one thermocouple for better precision.
Revert the whitespace differences in main.cpp (compared to the original fork)
|
After discussion with AnHard, will submit pull request to marlinDev instead |
|
When can Dyze support be added to the current RC5bugfix? |
|
@adamfilip A couple of weeks ago, this might have made it into the 1.1.0 release., but we've frozen features and are not accepting any new hardware support today. |
|
I opened a pull request on MarlinDev sometimes ago in order to add the high temperature thermistor support to the dev branch, and hopefully make that available in a future release. https://github.com/MarlinFirmware/MarlinDev/pull/374 I'm not too sure how the the pull request process works, but if there is anything I can do to make reviewing or integrating my changes easier, feel free to ask. I'm also available if my code needs some reworking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of : #2915
As discussed, I moved most of the preheating setup in setTargetHotend,
Both MILLISECONDS_PREHEAT_TIME and MAX_CONSECUTIVE_LOW_TEMPERATURE_ERROR_ALLOWED have been added to Configuration.h, and their value set to zero by default (meaning the feature is off by default). I did my best to explain what both variable are used for in the comments.
Added the thermistor table for high temperature thermistors in thermistors.h