Don't reject 8.3-filenames with chars > 0x7f #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't mangel 8.3-filenames with chars > 0x7f Windows produces 8.3filenames wit chars > 0x7f. Those have been rejected by Marlin until now. With these 'malformed' filenames can now be worked with: In the LCD menue With RepetierHost (V1.6.1 tested) - full support. Characters are displayed as '?' With Octoprint (1.2.10 tested) the files do not appear in the files area. At the console, listed with M20 they appear with a '�'. With Pronterface the files appear in the sd-window but you can't start them. They are mangled by pronterface. The names are altered and than recected by Marlin. In the console they apper with differen but not the correct characters. All in all a little step forward. Fix for MarlinFirmware#3593
Blue-Marlin
added a commit
to Blue-Marlin/Makaira
that referenced
this pull request
May 2, 2016
Fix for #6 3593, MarlinFirmware#3648 this time excludung 'DEL' instead of accidently '~'.
nomukaiki
pushed a commit
to nomukaiki/Marlin
that referenced
this pull request
May 4, 2016
Fix for MarlinFirmware#6 3593, MarlinFirmware#3648 this time excludung 'DEL' instead of accidently '~'.
CONSULitAS
pushed a commit
to CONSULitAS/Marlin-K8200
that referenced
this pull request
Aug 18, 2016
Fix for MarlinFirmware#6 3593, MarlinFirmware#3648 this time excludung 'DEL' instead of accidently '~'.
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
Nov 8, 2023
cleanup: Expand tabs to fixup suspicious indentation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't reject 8.3-filenames with chars > 0x7f
Windows produces 8.3-filenames with chars > 0x7f. Those have been rejected
by Marlin until now.
With these 'malformed' filenames can now be worked:
displayed as '?'
area. At the console, listed with M20 they appear with a '�'.
them. They are mangled by Pronterface. The names are altered and than
rejected by Marlin. In the console they appear with different but not the
correct characters.
All in all, a little step forward.
Fix for #3593