-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply config changes, tweak comments, next_ping_ms => next_idle_ms #3761
Apply config changes, tweak comments, next_ping_ms => next_idle_ms #3761
Conversation
An alternative could be to call Line 710 in dee6322
Finding an alternate condition for |
Perhaps it should be made possible to lower the display refresh rate with a variable, so we can still call |
f033504
to
aadf42e
Compare
aadf42e
to
b4075a3
Compare
Trying this idea with both |
The time between display updates is aboute 1s. Changing the comment does not change the fakts. - if (currentMenu == lcd_status_screen) {
- if (!lcd_status_update_delay) {
- lcdDrawUpdate = LCD_DRAW_UPDATE_CALL_REDRAW;
- lcd_status_update_delay = 10; /* redraw the main screen every second. This is easier then trying keep track of all things that change on the screen */
- }
- else {
- lcd_status_update_delay--;
- }
- }
+ // Simply redraw the Info Screen 10 times a second
+ if (currentMenu == lcd_status_screen && !(++lcd_status_update_delay % 10))
+ lcdDrawUpdate = LCDVIEW_REDRAW_NOW; Why this ugly, slow modulo division? |
I must have been lacking sleep or very stoned I wrote that. Obviously backward. Otherwise, valid concerns. Please propose/contribute alternatives/improvements. |
a5552ad
to
ce05a22
Compare
ce05a22
to
7145380
Compare
7145380
to
8218558
Compare
Recent changes were made to prevent watchdog timeout in very long arc moves. This involves calling
idle()
every 200ms. A side-effect of this call is some stuttering during arcs. This PR addresses the issue by only callingidle()
once out of 4 times, while only callingthermalManager.manage_heaters()
(which also resets the watchdog timer) the other 3 times.