Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune unmaintained languages #3772

Conversation

jbrazio
Copy link
Contributor

@jbrazio jbrazio commented May 16, 2016

Removes unmaintained Spanish language variations:

  • Aragonese (language_an.h)
  • Basque-Euskera (language_eu.h)
  • Catalan (language_ca.h)
  • Galician (language_gl.h)

For now we still keep unmaintained:

Closes: #3357, #3354, #3349, #3347

This PR has the side effect of move example_configurations/Felix/Configuration_DUAL.h into its own DUAL folder and renaming it to Configuration.h. This is so the config file can be catched when doing mass edits based on find . -name Configuration.h | xargs <something>.

@thinkyhead
Copy link
Member

thinkyhead commented May 17, 2016

Aww… I love being able to tell people Marlin supports "dozens" of languages.
Now I'll be an even bigger liar! 😄

@jbrazio
Copy link
Contributor Author

jbrazio commented May 17, 2016

Well these are non mainstream languages..
(I'm trying to see where they are hidden so we can convince them to update the language files :-)

@thinkyhead
Copy link
Member

@jbrazio It probably will happen that after 1.1.0 release, the language maintainers will appear with patches. But maybe not before. Have you messaged the individuals who made the most recent commits to these languages already?

@jbrazio
Copy link
Contributor Author

jbrazio commented May 18, 2016

@thinkyhead All of them have been pinged, if no reply within a week this PR should be merged.
All of the languages on this PR had the first commit and no more updates on the native language, all the following updates on the blame history were English additions.

@rafacouto
Copy link
Contributor

Galician syncronized at the moment. Thank you for pinging to me 👍

@jbrazio
Copy link
Contributor Author

jbrazio commented May 18, 2016

Thank you for your contribution @rafacouto !

@CONSULitAS
Copy link
Contributor

@jbrazio
@rafacouto
We have discussed the idea of language care takers before.

Should we add a header to maintained translations with the care taker(s) like in https://github.com/MarlinFirmware/Marlin/blob/RC/Marlin/example_configurations/K8200/Configuration.h#L23 ?

So it would be easier to find natives for the next update...

@jbrazio
Copy link
Contributor Author

jbrazio commented May 19, 2016

I like the idea, but how about using github teams ?
This way we could ping them with the "@" thing.

@MarlinFirmware/lang-en
@MarlinFirmware/lang-pt
@MarlinFirmware/lang-de
etc

Or have a unique @MarlinFirmware/localization-team with all the lang people inside, usually it's more than one lang file that needs updating.

@Roxy-3DPrintBoard

@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented May 19, 2016

In my opinion the unmaintained languages should be kept in.
For German i know there are dozens of 'personal' translations out there. The hurdles are not, to change some translations for your self but to judge is they are acceptable for a bigger audience and to do the PR with github. Removing the examples for the languages would make the hurdle for these 'personal' translation much higher.

@rafacouto
Copy link
Contributor

I am going to give it a try to this script: https://github.com/nevik/gitwatch

Another option could be a webhook to watch changes on the main language file and send an email to the maintainers declared in the header of the language files (@CONSULitAS ' idea).

@jbrazio jbrazio added the S: Don't Merge Work in progress or under discussion. label May 19, 2016
@jbrazio jbrazio removed this from the 1.1.0 milestone May 30, 2016
@jbrazio
Copy link
Contributor Author

jbrazio commented Jul 13, 2016

Closing due the creation of @MarlinFirmware/language-team.
Still some languages are problematic and lack maintainers.

@jbrazio jbrazio closed this Jul 13, 2016
@jbrazio jbrazio deleted the feature/prune-unmaintained-languages branch July 13, 2016 23:44
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: General Cleanup S: Don't Merge Work in progress or under discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants