-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise the servo probe before stow outside ABL context #3942
Raise the servo probe before stow outside ABL context #3942
Conversation
Where in the (original) code is the raise before servo stow done when ABL is enabled? I'm unable to locate the specific line. |
Haha. Fooled by your macros?
|
@AnHardt Thanks, I could not find it either, I only experienced it... The thing I designed and printed is nothing but a surface mount switch that the servo places in between the bed and the extruder tip... Advantages? a Z-offset and NO X nor Y offset... nearly free if you care to dismount old mouses (you still have to invest time...) absolutely reliable if you think the number of click per day for a mouse... Mouses seldom die because of a switch failure, the cable is perfect for endstop signal and if USB the cable is even twisted pair... I like mouses :-) |
Now, we can discuss what is the bug??? the fact that the servo deploys outside ABL context OR the fact that it retract without first raising.. I prefer to think that retract without raising is the bug... It fits better my needs when I decide that I do NOT need probing the bed with MBL. |
Thanks @AnHardt. Yes, to some extent I was/am confused by my own macros! Especially since |
@lrpirlet Well, we certainly do want a Z servo to deploy in But ultimately we need to make these raise/lower items available as general probing (including homing) options, and not dependent on ABL. Like we recently did with |
Take a look at #3946, which adds onto this PR with some of the changes we've discussed here. |
@thinkyhead Impressive... that amount of change would have taken me weeks a few months back, several days now... You did it in less than 24 hours... That said, I do appreciate the changes made in #3946 and will test it sometime in the week-end... To anser your question, I really mean "MY" Motorized Mesh Bed Leveling. I copied @epatel code that drives his Z switch palced over the hot tip... Only I designed a thing that, monted on a Z servo, moves a tiny SMB switch between the tip and the bed. If interrested have a look at this fully funtional branch https://github.com/lrpirlet/Marlin/tree/motorized_mesh_bed_leveling_for_LRP My goal now is to do that work again over an RCBugFix based branch modified with the LIN_ADVANCE algorithm. |
That's why I get paid the big bucks. Or, rather… the big thumbs ups.
Sounds good @lrpirlet !
I've been keeping the |
@thinkyhead Thanks for that reference about your LIN_ADVANCE branch, I allready knew about it... and cloned it... Thanks also for the work to keep it current... |
This PR should ensure that the Z probe on a servo does raise before retract when used outside the ABL context.
Tested both within ABL context ( ABL enabled) and ouside ABL context (ABL disabled).