-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update travis to test for ULTRA and DOG LCD options #3993
Update travis to test for ULTRA and DOG LCD options #3993
Conversation
Travis testing is now taking over 6 min with these additions. Not bad. But to reduce the duration of the test, we could combine various options together, such as one LCD option plus one or more add-on features (that are compatible). I've done this already in a couple of spots. |
This is redundant and unneeded. The options are already tested with |
@Blue-Marlin what's your name ? I prefer to treat people by their names. Try in your clone of RCBugfix, on the default config, enable only the ULTRA LCD flag. What happens ? |
The same is if i define Call me Blue, or Marlin, or Makaira if you want. This account is anonymous by purpose. (Or ask Roxy or Thinky who i may am.) |
Interesting. Not in today's RCBugFix. There the error only occures with |
I searched and I don't find anything in the recent blame logs which influences this broken behavior with ULTRA LCD. I found it out by coincidence when I was defining a Travis test for buzzer and speaker. |
The error makes sense. void lcd_update() {
#if ENABLED(ULTIPANEL)
static millis_t return_to_status_ms = 0;
+ manage_manual_move();
#endif
- manage_manual_move(); |
Makes sense your explanation, thanks. |
Sorry. No time for the next 8 -10 hours. |
Yup, that's it.