Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis to test for ULTRA and DOG LCD options #3993

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

jbrazio
Copy link
Contributor

@jbrazio jbrazio commented Jun 10, 2016

Yup, that's it.

@jbrazio jbrazio added this to the 1.1.0 milestone Jun 10, 2016
@thinkyhead
Copy link
Member

Travis testing is now taking over 6 min with these additions. Not bad. But to reduce the duration of the test, we could combine various options together, such as one LCD option plus one or more add-on features (that are compatible). I've done this already in a couple of spots.

@thinkyhead thinkyhead merged commit 4a212f7 into MarlinFirmware:RCBugFix Jun 10, 2016
@Blue-Marlin
Copy link
Contributor

This is redundant and unneeded. The options are already tested with REPRAP_DISCOUNT_SMART_CONTROLLER and REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER.

@jbrazio
Copy link
Contributor Author

jbrazio commented Jun 10, 2016

@Blue-Marlin what's your name ? I prefer to treat people by their names.

Try in your clone of RCBugfix, on the default config, enable only the ULTRA LCD flag. What happens ?

@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented Jun 10, 2016

The same is if i define REPRAP_DISCOUNT_SMART_CONTROLLER. I get a error about manage_manual_move() not declared.
That means Travis is broken again - not we need an other test.

Call me Blue, or Marlin, or Makaira if you want. This account is anonymous by purpose. (Or ask Roxy or Thinky who i may am.)

@Blue-Marlin
Copy link
Contributor

Interesting. Not in today's RCBugFix. There the error only occures with ULTRA LCD. ???

@jbrazio
Copy link
Contributor Author

jbrazio commented Jun 10, 2016

I searched and I don't find anything in the recent blame logs which influences this broken behavior with ULTRA LCD.

I found it out by coincidence when I was defining a Travis test for buzzer and speaker.

@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented Jun 10, 2016

The error makes sense.
ULTRA_LCD is the pure display with no buttons, encoders, ... only. (can display the status screen - nothing else)
For manage_manual_move(); you need a gadget to move in the menus. therefore you need a panel.
ULTIPANEL is the base for all panels. So:

void lcd_update() {
  #if ENABLED(ULTIPANEL)
    static millis_t return_to_status_ms = 0;
+   manage_manual_move();
  #endif

-  manage_manual_move();

@jbrazio jbrazio deleted the feature/update-travis branch June 10, 2016 11:15
@jbrazio
Copy link
Contributor Author

jbrazio commented Jun 10, 2016

Makes sense your explanation, thanks.
Will you submit that diff as a PR ?

@Blue-Marlin
Copy link
Contributor

Sorry. No time for the next 8 -10 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants