Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lin advance timing patch #4123

Conversation

Sebastianv650
Copy link
Contributor

@Sebastianv650 Sebastianv650 commented Jun 22, 2016

Fixes #4114. Forgot to keep track of the step_loops value inside the estepper ISR..

Edit: No idea why it shows 3 Commits - I'm not smart enough for GitHub.

Sebastianv650 added 3 commits May 4, 2016 18:50
Also the extruder stepper ISR has to keep an eye on step_loops count.
@thinkyhead
Copy link
Member

thinkyhead commented Jun 23, 2016

I'm just following up in this manner…

git fetch sebastian    ;# already had this set up
git checkout sebastian/LIN_ADVANCE-timing-patch -b rc_lin_timing_patch
git rebase RCBugFix    ;# use my up-to-date local as new base
git rebase -i RCBugFix ;# squash commits (but none needed after rebase)
mfpr                   ;# script to make a new PR

Looks like all you need to do to bring this PR up to date is actually…

git fetch upstream
git rebase upstream/RCBugFix
git push -f

@thinkyhead
Copy link
Member

thinkyhead commented Jun 23, 2016

I thought, for some reason, that step loops had been made obsolete by the variable stepper ISR timing. I guess not!

Q: This should also apply to regular ADVANCE extrusion, correct?

@Sebastianv650
Copy link
Contributor Author

Yes, that's also true for ADVANCE.
At some point the timer resolution isn't sufficient, meaning eISRrate is approaching 0. I guess it will also block other things if an isr is fired at 20khz for example.

@thinkyhead
Copy link
Member

We do have to be cautious about those ISRs. And always remember the maxim, "To make it go faster, make it do less."

@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
@Sebastianv650 Sebastianv650 deleted the LIN_ADVANCE-timing-patch branch October 8, 2016 15:52
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
Minor UI fixes for MMU status line during toolchange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants