Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dock_sled() and some more probe tweaks #4162

Merged
merged 3 commits into from
Jun 28, 2016
Merged

Simplify dock_sled() and some more probe tweaks #4162

merged 3 commits into from
Jun 28, 2016

Conversation

thinkyhead
Copy link
Member

See #4160

@AnHardt @thinkyhead
Simplify dock_sled()
e616093 
`dock_sled()` is never called with offset parameter - remove it.
We move x only - so only that needs to be homed. Consequence is - we can home to z-min now with a sled probe!
Feedrates are set and restored in `do_blocking_move()`.
We already checked if the probe is deployed/stowed in deploy/stow_probe.
```
if (z_loc < _Z_RAISE_PROBE_DEPLOY_STOW + 5) z_loc = _Z_RAISE_PROBE_DEPLOY_STOW;
```
makes no sense - remove.
Now the raise is the same for deploy/stow -> move before the if.
Replace the if with a ternary.
Instead writing LOW/HIGH use the boolean `stow` we already have.

There is no reason for not using the sled probe in G29/M48 with 'E'.
It takes a while but works. (tested!)
@AnHardt @thinkyhead
universalize axis_unhomed_error()
39883d0
@AnHardt @thinkyhead
Further cleanup of G28 for probes
e480ee0
@thinkyhead thinkyhead merged commit fdb6533 into MarlinFirmware:RCBugFix Jun 28, 2016
@thinkyhead thinkyhead deleted the rc_anhardt_sled3 branch June 28, 2016 03:35
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Closed
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
@leptun
Merge pull request MarlinFirmware#4162 from leptun/fix_lcd_encoder_diff
ae75d9b 
Fix `lcd_encoder_diff` getting out of sync with the knob hard steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
F: Calibration PR: Bug Fix PR: Improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thinkyhead @jbrazio @AnHardt