Additional patches for gcode_T position change #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
Nov 8, 2023
optimisation: always inline `ReportingRAII`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #4202
Utilize the actual modified XY when adjusting current position and position shift.
The use of
position_shiftmay seem odd ingcode_T. But note that a nozzle 10mm to the right has 10mm less freedom of movement on the left end, but 10mm more freedom to the right, so we shift the coordinate space (software endstops) to the right to indicate this aspect.