-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix raise by MIN_Z_HEIGHT_FOR_HOMING (first attempt) #4217
Fix raise by MIN_Z_HEIGHT_FOR_HOMING (first attempt) #4217
Conversation
} | ||
#endif | ||
do_blocking_move_to_z(z_dest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this work? do_blocking_move_to_z()
is only defined if HAS_BED_PROBE
is defined.
89c676a
to
c844a45
Compare
#endif | ||
|
||
SYNC_PLAN_POSITION_KINEMATIC(); | ||
do_blocking_move_to_z(destination[Z_AXIS]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If MIN_Z_HEIGHT_FOR_HOMING
is defined you get.
Marlin_main.cpp:2898: error: 'do_blocking_move_to_z' was not declared in this scope
do_blocking_move_to_z(destination[Z_AXIS]);
Because do_blocking_move_to_z()
is only defined if HAS_BED_PROBE
c844a45
to
0d64626
Compare
0d64626
to
d7e9647
Compare
current_position[Z_AXIS] = destination[Z_AXIS]; | ||
// Raise Z before homing any other axes and z is not already high enough (never lower z) | ||
float z_dest = (current_position[Z_AXIS] += MIN_Z_HEIGHT_FOR_HOMING); | ||
#if ENABLED(DEBUG_LEVELING_FEATURE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you'll stay with this crap - at least change the comment above.
The fix could be to reactivate the normal routines and remove the attempt to home the second axis. For me the initial rise is completely broken now. Consecutive homings of x or y rise and rise and rise and ... . |
Yeah, sorry, I misconstrued the logic there. It's reverted by the above PR, but keeping the
If you're using |
When doing the initial raise for homing (which occurs before homing X and Y) we don't need to include the probe offset. This lift is just always done over the current Z position. The Z axis will be lifted more, if needed later, to deploy the probe before homing Z.
Reference: #4208