Runout sensor without SD Card and updating print timer behaviour #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runout sensor without SD Card
| */ | ||
| #if ENABLED(FILAMENT_RUNOUT_SENSOR) | ||
| #if !HAS_FIL_RUNOUT | ||
| #error "FILAMENT_RUNOUT_SENSOR requires FIL_RUNOUT_PIN." | ||
| #elif DISABLED(SDSUPPORT) | ||
| #elif DISABLED(SDSUPPORT) && DISABLED(PRINTJOB_TIMER_AUTOSTART) | ||
| #error "FILAMENT_RUNOUT_SENSOR requires SDSUPPORT." |
There was a problem hiding this comment.
#error "FILAMENT_RUNOUT_SENSOR requires SDSUPPORT or PRINTJOB_TIMER_AUTOSTART."
| if (no_wait_for_cooling || code_seen('R')) { | ||
| thermalManager.setTargetBed(code_value_temp_abs()); | ||
| #if ENABLED(PRINTJOB_TIMER_AUTOSTART) | ||
| if(code_value_temp_abs() > BED_MINTEMP) { |
There was a problem hiding this comment.
This should produce slightly more optimal code, with one less call to code_value_temp_abs:
const float temp = code_value_temp_abs();
thermalManager.setTargetBed(temp);
#if ENABLED(PRINTJOB_TIMER_AUTOSTART)
if (temp > BED_MINTEMP) {
. . .There was a problem hiding this comment.
…or not. The compiler will use its own temporary when juggling the return value of non-volatile functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling runout sensor without SD card as well. For example, for sending g-code from desktop computer (Repetier-Host, slicer etc.) or from Raspberry Pi (octoprint etc.). Print timer is used for this feature (print statistics). We enhanced print timer triggers so bed heating will start timer too, and extruder heating without wait will not start timer:
M104 (extruder without wait) - high temp = none, low temp = stop timer
M109 (extruder with wait) - high temp = start timer, low temp = stop timer
M140 (bed without wait) - none
M190 (bed with wait) - high temp = start timer, low temp = none