Renamed timestamp_t to duration_t #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In M31: SERIAL_ECHO_START;
SERIAL_ECHOPGM(MSG_PRINT_TIME " ");
SERIAL_ECHOLN(buffer);Are you sure you want to translate "Print time"? I've always seen Serial messages as untranslated. |
|
Good point, I would say no. |
| @@ -4064,7 +4064,7 @@ inline void gcode_M31() { | |||
| lcd_setstatus(buffer); | |||
|
|
|||
| SERIAL_ECHO_START; | |||
| SERIAL_ECHOPGM(MSG_PRINT_TIME " "); | |||
| SERIAL_ECHOPGM("Print time: "); | |||
There was a problem hiding this comment.
So MSG_PRINT_TIME isn't used anymore, right? Should be removed from language files ASAP (#4395)
Closed
|
This one is merged, but I can still see |
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
May 31, 2024
MBL: Add magnet compensation parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Scott, "duration" is a better term for this structure.