M408

[akaJes]

http://reprap.org/wiki/G-code#M408:_Report_JSON-style_response
+802 bytes

[bgort]

Out of curiosity, what's the (or your) use case for this?

[bgort]

This and the following one are already covered by line 120.

[akaJes]

these were auto appended with gui

[akaJes]

@bgort I would like to create a web interface
@thinkyhead have you some seconds to look at this PR ?

[bgort]

I don't see any reason not to merge this. It's conditionally compiled, and as long as it works, I can't see how it hurts anything. Let's give @thinkyhead a bit longer to comment and then I'll merge it.

[thinkyhead]

Enable the option in one of the other tests, rather than requiring an additional build.

[akaJes]

which is more prefered? PRINTCOUNTER ?

[thinkyhead]

SERIAL_PROTOCOLCHAR(']');

[thinkyhead]

These custom print statements that create key/value strings should probably be implemented as a small function taking the key and value. The code will likely end up smaller.

[akaJes]

I thought about this, but don't see good solution yet

[thinkyhead]

A single key-value output would be…

void floatkey(const char *pstr, const float &val, const bool comma=false) {
  SERIAL_CHAR('"'); serialprintPGM(pstr); SERIAL_CHAR('"');
  SERIAL_CHAR(':'); SERIAL_ECHO(val);
  if (comma) SERIAL_ECHO(',');
}

And a function for XYZ elements…

void xyzkey(const char *pstr, const float val[XYZ], const bool comma=false) {
  SERIAL_CHAR('"'); serialprintPGM(pstr); SERIAL_CHAR('"');
  SERIAL_ECHO(":[");
  SERIAL_ECHO(val[X_AXIS]); SERIAL_CHAR(',');
  SERIAL_ECHO(val[Y_AXIS]); SERIAL_CHAR(',');
  SERIAL_ECHO(val[Z_AXIS]);
  SERIAL_CHAR(']');
  if (comma) SERIAL_ECHO(',');
}

[thinkyhead]

Please put else if keywords together on the same line. Or use this:

SERIAL_PROTOCOLCHAR(
  !planner.blocks_queued()                        ? 'I' : // IDLING
  (IS_SD_PRINTING || print_job_timer.isRunning()) ? 'P' : // SD Printing
  print_job_timer.isPaused()                      ? 'A' : // PAUSED
                                                    'B'   // SOMETHING ELSE
);

[thinkyhead]

SERIAL_PROTOCOLCHAR('}');

[thinkyhead]

Something screwy is going on here. The base was changed to bugfix-2.0.x on July 31, but the PR has changes to Marlin_main.cpp, which is only in the 1.1 layout.

Please redo.