Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XY Skew correction #3839 #8159

Closed
wants to merge 1 commit into from

Conversation

Paciente8159
Copy link

Hi there.
I've been fixing my printer bed skew via firmware.
I'v implemented the change to the code to address #3839
XY Skew factor is defined via M852 F(value) comand.
Value is stored in EEPROM.

XY Skew factor defined via M852 F(value) comand.
Value is stored in EEPROM.
@Grogyan
Copy link
Contributor

Grogyan commented Oct 30, 2017

Might be a good idea to have a calculator on the MarlinFW wiki too to help compute the correction factor

@Allted
Copy link
Contributor

Allted commented Oct 30, 2017

Would it be much harder to add it to the xz or yz axis as well? This is too cool and could really help get more accurate prints for those that care to set it.
It seems that tiny build errors that would be hard to physically adjust out could really use this. Most printers have no physical way to adjust them.

@Paciente8159
Copy link
Author

Paciente8159 commented Oct 30, 2017

Would it be much harder to add it to the xz or yz axis as well?

That can be done.
I'll try to modify the code during this week and test it in order to take the bed/z skew in account.
I'll do a printable test part for it too.

@Allted
Copy link
Contributor

Allted commented Oct 30, 2017

I hope that didn't come off rude or pushy I just figure might as well get them both in there at the same time. This does seem like it might be something a slicer could do as well but if it can be done in the firmware than even better. Thanks for working on this.

@Paciente8159
Copy link
Author

I hope that didn't come off rude or pushy ...

Not at all. I've just addressed this matter since I felt the need to get proper printing dimensions without being slicer dependent (and the funny coincidence is that I actually decided to tested my printer for skew issues after printing some of the parts for the MPCNC, lolol).

But now thinking of the XZ/YZ skew problem, my main concern is the effect of bed leveling + skew fixing.
I got to study this carefully.

@Allted
Copy link
Contributor

Allted commented Oct 30, 2017

LOL I think my parts are some of the first that make people realize how far off there printers are! Ahhh the bed leveling Good point. Maybe start with just make it for people that don't use bed leveling. I know a majority of the users use bed leveling but maybe that will nudge them to just manually leveling there bed? Not an ideal solution but it lets some of us try it. I should actually see how far off my printers are, I have checked a few times and it did seem minimal at the time. I will try to come up with a part that can be accurately measured without first layer heights affecting it too much.

@Paciente8159
Copy link
Author

I've added a vertical test piece to https://www.thingiverse.com/thing:2563185.
Check if it fits your needs.

@thinkyhead
Copy link
Member

Alas, all submissions must be based upon and submitted to the bugfix-1.1.x and/or bugfix-2.0.x branches. Please recreate and resubmit for a proper review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants