[2.0.x] Update of comments in thermistor files. No functional changes. #8986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABH10
changed the title
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
5f5ed36
to
db031d5
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x-thermistor-tables
branch
from
9286e6f
to
501fd37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of mistakes in the comments for various thermistor tables. I checked all the bed thermistor tables (not Pt100 tables) and updated the comments.
One issue is reported here:
#8862
Table 8 is for 10k pull-up and beta_25 == 3950. Device name is NTCS0402E3104FHT, not NTCS0603E3104FXT.
Table 12 is for 4.7k pull-up and beta_25 == 4700K, not for beta_25 == 4100K
Table 13 is for 4.7k pull-up and beta_25 == 4700K, not for beta_25 == 3950K
Table 6 is supposed to be an alternative EPCOS linearization. Assuming that the "EPCOS" device has R25 == 100 kOhm and beta25 = 4092K, then the only pull-up that gives reasonable (but not very good) results is 8.2 kOhm. A 4.7kOhm pull-up cannot give reasonable results for any beta25 value.
It seems that some of these tables are results of peoples measurements, which doesn't make sense. The tables that are included in Marlin should correspond to nominal values of thermistor parameters and nominal values of pull-up resistors. Nominal values, as given in datasheets for a particular NTC resistor are supposed to be the best general fit in average. People can make fine-tuned tables from measurements on their own devices and circuits, but such tables are not relevant in general.