Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TouchEvent is not defined #88

Closed
German-GM opened this issue May 27, 2020 · 4 comments · Fixed by #89
Closed

TouchEvent is not defined #88

German-GM opened this issue May 27, 2020 · 4 comments · Fixed by #89
Labels
Priority: High Issues that break most user's experience Status: In Progress Currently assigned and being worked on Type: Bug Something isn't working

Comments

@German-GM
Copy link

German-GM commented May 27, 2020 •
edited
Loading

Versions

  • 1.7.1

Describe the bug

When trying to dismiss a toast on click, the console shows an "Uncaught ReferenceError: TouchEvent is not defined" at "node_modules\vue-toastification\dist\esm\index.js".

Expected behavior

The toast should dismiss correctly on click and with the corresponding animation.

Your Environment

  • OS: W10 & Linux
  • Browser: Firefox 76.0.1
@German-GM German-GM added Status: Available Type: Bug Something isn't working labels May 27, 2020
@Maronato Maronato added Priority: High Issues that break most user's experience Status: In Progress Currently assigned and being worked on and removed Status: Available labels May 28, 2020
@Maronato
Copy link
Owner

Turns out most desktop browsers do not implement touch events. Crazy!

Thanks a lot for the report! I'm working on it right now and should release a fix in the next few minutes.

@Maronato Maronato mentioned this issue May 28, 2020
Merged
9 tasks
@Maronato
Copy link
Owner

Fixed on 1.7.2. Please give it a try and report back if the issue persists :)

@German-GM
Copy link
Author

Sure thing, though it seems like it's all good now, thank you!

@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Priority: High Issues that break most user's experience Status: In Progress Currently assigned and being worked on Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing TouchEvent on some desktop browsers Maronato/vue-toastification
2 participants
@Maronato @German-GM