Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing TouchEvent on some desktop browsers #89

Merged
merged 1 commit into from
May 28, 2020

Conversation

Maronato
Copy link
Owner

Description

Some desktop browsers do not implement TouchEvent at all. This PR resolves that by checking if TouchEvent is available.

Also updates some required packages because Node 13 requires it

Related Issue

Resolves #88

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Maronato Maronato added the Type: Bug Something isn't working label May 28, 2020
@Maronato Maronato self-assigned this May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          360       360           
  Branches        76        77    +1     
=========================================
  Hits           360       360           
Impacted Files Coverage Δ
src/ts/interface.ts 100.00% <ø> (ø)
src/ts/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1d037...9bec19d. Read the comment docs.

@Maronato Maronato merged commit e5411c3 into master May 28, 2020
@Maronato Maronato deleted the fix-missing-TouchEvent branch May 28, 2020 18:40
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

2 similar comments
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TouchEvent is not defined
1 participant