-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration script to remove size limits from namespaces, dataset n… #1925
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
.../resources/marquez/db/migration/V40__alter_tables_resize_namespace_and_connection_url.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
ALTER TABLE dataset_versions ALTER COLUMN namespace_name TYPE VARCHAR; | ||
ALTER TABLE dataset_versions ALTER COLUMN dataset_name TYPE VARCHAR; | ||
ALTER TABLE datasets ALTER COLUMN name TYPE VARCHAR; | ||
ALTER TABLE datasets ALTER COLUMN physical_name TYPE VARCHAR; | ||
ALTER TABLE datasets ALTER COLUMN source_name TYPE VARCHAR; | ||
ALTER TABLE namespaces ALTER COLUMN name TYPE VARCHAR; | ||
ALTER TABLE runs ALTER COLUMN external_id TYPE VARCHAR; | ||
ALTER TABLE sources ALTER COLUMN name TYPE VARCHAR; | ||
ALTER TABLE sources ALTER COLUMN connection_url TYPE VARCHAR; | ||
ALTER TABLE tags ALTER COLUMN name TYPE VARCHAR; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these are to change from VARCHAR(256) to VARCHAR, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep