Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix symlink table column length #2217

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

pawel-big-lebowski
Copy link
Collaborator

@pawel-big-lebowski pawel-big-lebowski commented Oct 27, 2022

Signed-off-by: Pawel Leszczynski [email protected]

Problem

Dataset's name column in dataset_symlinks table is shorter than column in datasets table.

Closes: #2216

Solution

  • Change the existing V48 migration script to allow proper migration for users who did not upgrade yet,
  • Add extra migration script to extend column length for users who did upgrade but did not experience the issues.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the api API layer changes label Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #2217 (6b50627) into main (a7f88b0) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 6b50627 differs from pull request most recent head a8d5895. Consider uploading reports for the commit a8d5895 to get more accurate results

@@             Coverage Diff              @@
##               main    #2217      +/-   ##
============================================
- Coverage     76.72%   76.67%   -0.05%     
+ Complexity     1147     1144       -3     
============================================
  Files           219      219              
  Lines          5318     5312       -6     
  Branches        423      421       -2     
============================================
- Hits           4080     4073       -7     
- Misses          763      764       +1     
  Partials        475      475              
Impacted Files Coverage Δ
...pi/src/main/java/marquez/db/mappers/RunMapper.java 83.67% <0.00%> (-5.01%) ⬇️
.../src/main/java/marquez/service/LineageService.java 85.32% <0.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🥇 Sorry, approved too soon! (Some good discussion is happening below).

@wslulciuc wslulciuc self-requested a review October 27, 2022 17:24
Signed-off-by: Pawel Leszczynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: value too long for type character varying(255)
4 participants