-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update migration query to make it work with existing view #2308
Merged
fm100
merged 1 commit into
MarquezProject:main
from
fm100:bugfix/drop-view-before-altering
Dec 12, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 27 additions & 1 deletion
28
api/src/main/resources/marquez/db/migration/V52__alter_dataset_symlinks.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,28 @@ | ||
/* SPDX-License-Identifier: Apache-2.0 */ | ||
ALTER TABLE dataset_symlinks ALTER COLUMN name TYPE VARCHAR; | ||
|
||
DO | ||
$$ | ||
DECLARE | ||
datasets_view_exists boolean; | ||
datasets_view_definition text; | ||
BEGIN | ||
SELECT EXISTS ( | ||
SELECT * FROM information_schema.views | ||
WHERE table_schema='public' AND table_name='datasets_view' | ||
) INTO datasets_view_exists; | ||
|
||
IF datasets_view_exists THEN | ||
-- Altering is not allowed when the column is being used from views. So here, | ||
-- we temporarily drop the view before altering and recreate it. | ||
SELECT view_definition FROM information_schema.views | ||
WHERE table_schema='public' AND table_name='datasets_view' | ||
INTO datasets_view_definition; | ||
|
||
DROP VIEW datasets_view; | ||
ALTER TABLE dataset_symlinks ALTER COLUMN name TYPE VARCHAR; | ||
EXECUTE format('CREATE VIEW datasets_view AS %s', datasets_view_definition); | ||
ELSE | ||
ALTER TABLE dataset_symlinks ALTER COLUMN name TYPE VARCHAR; | ||
END IF; | ||
END | ||
$$ LANGUAGE plpgsql; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's an overkill, as
at the beginning of the script should be enough as in PR:
https://github.com/MarquezProject/marquez/pull/2313/files