Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset loading for web #2323

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Fix asset loading for web #2323

merged 4 commits into from
Dec 15, 2022

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Dec 14, 2022

Problem

Since we updated the webpack version our asset loading broke and this has resulted in us having to make some undesirable changes to load images from remote instead of local sources.

Solution

This fixes the webpack configuration and allows for files to be imported in a more modern capacity that enforces the assets actually exist.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #2323 (467e806) into main (bc27201) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2323   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1177     1177           
=========================================
  Files           222      222           
  Lines          5354     5354           
  Branches        429      429           
=========================================
  Hits           4108     4108           
  Misses          768      768           
  Partials        478      478           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -2,3 +2,5 @@ declare module '*.css' {
const content: any;
export = content;
}

declare module '*.svg';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially add other asset types here in the future, .jpg .png for example.

@phixMe phixMe marked this pull request as ready for review December 14, 2022 22:28
@wslulciuc
Copy link
Member

@phixMe, looks like you'll have to sign your commits, but otherwise this looks great!

@wslulciuc wslulciuc merged commit a2a63ae into main Dec 15, 2022
@wslulciuc wslulciuc deleted the fix/webpack_assets branch December 15, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants