Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Version API spec update #2389

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Dataset Version API spec update #2389

merged 4 commits into from
Jan 31, 2023

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Jan 31, 2023

Problem

limit and offset are missing from the openapi.yml spec file.

Solution

Adding them as query parameters.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@phixMe phixMe requested a review from wslulciuc January 31, 2023 04:56
@boring-cyborg boring-cyborg bot added the spec label Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #2389 (6a42aa6) into main (162918a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2389   +/-   ##
=========================================
  Coverage     77.11%   77.11%           
  Complexity     1234     1234           
=========================================
  Files           228      228           
  Lines          5572     5572           
  Branches        447      447           
=========================================
  Hits           4297     4297           
  Misses          775      775           
  Partials        500      500           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc enabled auto-merge (squash) January 31, 2023 06:30
@phixMe phixMe merged commit 406daaf into main Jan 31, 2023
@phixMe phixMe deleted the fix/api-spec-dataset-versions branch January 31, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants