Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes the communication of the Web UI component with Marquez AP… #2430

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

thomas-delrue
Copy link
Contributor

…I service in the Helm Chart

Problem

Deploying the current Helm Chart in main results in a broken Marquez Web Component because of a misconfiguration in the Helm Chart. In the container spec in the Web deployment.yaml file two environment variables are set, i.e. MARQUEZ_HOST and MARQUEZ_PORT, for the instance to be able to communicate with the Marquez API service in the K8s cluster.

The MARQUEZ_PORT is erroneously set to 5000, .Values.marquez.port, the port number used internally in the container for the API, but the Marquez API service is exposed via port number 80, .Values.service.port, within the K8s cluster

Solution

Small fix: define the value for MARQUEZ_PORT as .Values.service.port, i.e. 80. That way Marquez Web component can communicate via http://marquez:80 with the API backend.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

…I service in the Helm Chart

Signed-off-by: DELRUE Thomas <[email protected]>
@boring-cyborg boring-cyborg bot added the chart label Feb 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 21, 2023

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@thomas-delrue thomas-delrue changed the title This fixes the communication of the Web UI componennt with Marquez AP… This fixes the communication of the Web UI component with Marquez AP… Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #2430 (3b21698) into main (79a9c4f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2430   +/-   ##
=========================================
  Coverage     83.61%   83.61%           
  Complexity     1214     1214           
=========================================
  Files           231      231           
  Lines          5522     5522           
  Branches        266      266           
=========================================
  Hits           4617     4617           
  Misses          762      762           
  Partials        143      143           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @thomas-delrue. Thanks!

@wslulciuc wslulciuc enabled auto-merge (squash) February 28, 2023 17:10
@wslulciuc wslulciuc merged commit 425ceba into MarquezProject:main Feb 28, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 28, 2023

Great job! Congrats on your first merged pull request in the Marquez project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants