Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null run.jobVersion in DatasetInfo #2471

Merged

Conversation

perttus
Copy link
Contributor

@perttus perttus commented Apr 5, 2023

Problem

In some cases Marquez UI fails to render DatasetInfo.

Closes: #2470

Solution

One-line summary: Handle null run.jobVersion in DatasetInfo.tsx

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Perttu Salonen <[email protected]>
@boring-cyborg boring-cyborg bot added the web label Apr 5, 2023
Signed-off-by: Perttu Salonen <[email protected]>
@boring-cyborg boring-cyborg bot added the docs label Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2471 (a360e02) into main (c038f73) will decrease coverage by 0.07%.
The diff coverage is 89.47%.

❗ Current head a360e02 differs from pull request most recent head 2c93e5e. Consider uploading reports for the commit 2c93e5e to get more accurate results

@@             Coverage Diff              @@
##               main    #2471      +/-   ##
============================================
- Coverage     83.60%   83.53%   -0.07%     
+ Complexity     1213     1207       -6     
============================================
  Files           231      231              
  Lines          5520     5503      -17     
  Branches        266      267       +1     
============================================
- Hits           4615     4597      -18     
  Misses          762      762              
- Partials        143      144       +1     
Impacted Files Coverage Δ
...a/marquez/db/migrations/V57_1__BackfillFacets.java 85.96% <89.47%> (-4.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pawel-big-lebowski pawel-big-lebowski merged commit 7f80746 into MarquezProject:main Apr 17, 2023
@perttus perttus deleted the fix/null-run-jobversion branch April 17, 2023 09:04
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
* handle null run.jobVersion

Signed-off-by: Perttu Salonen <[email protected]>

* updated changelog

Signed-off-by: Perttu Salonen <[email protected]>

---------

Signed-off-by: Perttu Salonen <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle null run.jobVersion in DatasetInfo.tsx
2 participants