-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary updates which are deadlock prone #2531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Leszczynski <[email protected]>
pawel-big-lebowski
force-pushed
the
fix-unnecessary-on-conflict
branch
from
June 29, 2023 13:45
47817e6
to
d8c1383
Compare
Codecov Report
@@ Coverage Diff @@
## main #2531 +/- ##
=========================================
Coverage 83.80% 83.80%
Complexity 1233 1233
=========================================
Files 235 235
Lines 5625 5625
Branches 270 270
=========================================
Hits 4714 4714
Misses 767 767
Partials 144 144
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wslulciuc
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
harels
pushed a commit
that referenced
this pull request
Jun 30, 2023
Signed-off-by: Pawel Leszczynski <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 5, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 5, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
) Signed-off-by: Pawel Leszczynski <[email protected]> Signed-off-by: Xavier Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix SQL syntax that could cause deadlocks
Closes: #2530
Solution
Get rid of unnecessary updates.
One-line summary:
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)