Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace, before, and after to searchAPI #2553

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Jul 27, 2023

Problem

The searchAPI does not support filtering search results by namespace or date. See related issue #2550

Solution

This PR adds for search results by namespace or date using the following query parameters:

  • namespace - will match jobs or datasets within the given namespace.
  • before - will match jobs or datasets before YYYY-MM-DD.
  • after - will match jobs or datasets after YYYY-MM-DD.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the spec label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2553 (55ad2a7) into feature/filter-search-by-namespace-or-date (50443ab) will not change coverage.
The diff coverage is n/a.

@@                              Coverage Diff                              @@
##             feature/filter-search-by-namespace-or-date    #2553   +/-   ##
=============================================================================
  Coverage                                         83.26%   83.26%           
  Complexity                                         1286     1286           
=============================================================================
  Files                                               243      243           
  Lines                                              5934     5934           
  Branches                                            279      279           
=============================================================================
  Hits                                               4941     4941           
  Misses                                              846      846           
  Partials                                            147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc merged commit 98638e4 into feature/filter-search-by-namespace-or-date Jul 28, 2023
2 checks passed
@wslulciuc wslulciuc deleted the feature/filter-search-by-namespace-or-date-spec branch July 28, 2023 08:16
wslulciuc added a commit that referenced this pull request Sep 14, 2023
* Add namespace and after query params

Signed-off-by: wslulciuc <[email protected]>

* continued: Add namespace and after query params

Signed-off-by: wslulciuc <[email protected]>

* continued: Add namespace and after query params

Signed-off-by: wslulciuc <[email protected]>

* Add before query param to search

Signed-off-by: wslulciuc <[email protected]>

* Add `namespace`, `before`, and `after` to searchAPI (#2553)

Signed-off-by: wslulciuc <[email protected]>

* Add namespace, before and after to SearchDao (#2555)

Add support for the following parameters in the SearchDao:
* `namespace` - match jobs or datasets within the given namespace.
* `before` - match jobs or datasets before YYYY-MM-DD.
* `after` - match jobs or datasets after YYYY-MM-DD.

Relates to issue: #2550

Signed-off-by: Tatiana Al-Chueyr <[email protected]>
Co-authored-by: Willy Lulciuc <[email protected]>

* Enforce `YYYY-MM-DD` for query params

Signed-off-by: wslulciuc <[email protected]>

* Use `YYYY-MM-DD` as `LocalDate`

Signed-off-by: wslulciuc <[email protected]>

---------

Signed-off-by: wslulciuc <[email protected]>
Signed-off-by: Tatiana Al-Chueyr <[email protected]>
Co-authored-by: Tatiana Al-Chueyr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant