Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signe code to do the PR #2563

Merged

Conversation

Xavier-Cliquennois
Copy link
Contributor

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Closes: None

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: The goal was to upgrade the web client to React 18 in order to utilize the latest version of Node.js and update all dependencies to their respective latest versions. Everything is good only the unit tests haven't been fully migrated to Jest and test-library for the moment.
This PR is a clone of the PR 2520. It just a signed version.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

This branch is a clone of renovate/web use for the PR MarquezProject#2520.
@Xavier-Cliquennois
Copy link
Contributor Author

Hello @phixMe, I just created this new PR to sign all the commits. Indeed, it would take me too much time to fix PR 2520. Thanks in advance for your understanding.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2563 (d4f117c) into main (58ad3e3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2563   +/-   ##
=========================================
  Coverage     83.26%   83.26%           
  Complexity     1286     1286           
=========================================
  Files           243      243           
  Lines          5934     5934           
  Branches        279      279           
=========================================
  Hits           4941     4941           
  Misses          846      846           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xavier-Cliquennois This is tight! Thanks for all the sweet upgrades! @phixMe since you approved #2520, I'm assuming we're good to merge.

@wslulciuc wslulciuc merged commit 6a512a1 into MarquezProject:main Aug 6, 2023
2 of 3 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 6, 2023

Great job! Congrats on your first merged pull request in the Marquez project!

@jlukenoff jlukenoff mentioned this pull request Aug 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants