-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] fix pagination in jobs route #2655
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #2655 +/- ##
=========================================
Coverage 83.35% 83.35%
Complexity 1295 1295
=========================================
Files 244 244
Lines 5948 5948
Branches 279 279
=========================================
Hits 4958 4958
Misses 844 844
Partials 146 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: merobi-hub <[email protected]>
53e8cd1
to
c6f95f1
Compare
Is this the same solution we use for datasets? Ideally, there would be a general purpose paging controller, but that is a bit out of scope here. |
@phixMe yes, this change refactors code that was basically the same as in datasets. Agree that a general purpose solution would be ideal. This will fix the pagination in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @merobi-hub
Problem
Unlike in the case of datasets, for jobs, page navigation is displayed whether or not there are jobs/pages in the namespace. The page total advances while the total job count remains zero.
Solution
This hides pagination when there are no jobs.
One-line summary: hides job pagination in the case of no jobs.
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)