-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dataset tags to allow editing/addition of tags #2759
Update dataset tags to allow editing/addition of tags #2759
Conversation
Signed-off-by: sharpd <[email protected]>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
============================================
+ Coverage 83.15% 84.45% +1.30%
- Complexity 1286 1416 +130
============================================
Files 244 251 +7
Lines 5942 6447 +505
Branches 282 291 +9
============================================
+ Hits 4941 5445 +504
+ Misses 854 850 -4
- Partials 147 152 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, Can you include a screenshot or video of the behavior for users to see the experience?
Signed-off-by: sharpd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Problem
Currently there is functionality to add tags at both a column and dataset level, however, there is no way of maintaining or adding tags unless you go through the API.
Closes: #2741
Solution
Update DatasetTags to include a split button menu and a new dialog/reducer for adding new tags.
One-line summary:
Add Tag dialog box
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)