Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset tags to allow editing/addition of tags #2759

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Feb 29, 2024

Problem

Currently there is functionality to add tags at both a column and dataset level, however, there is no way of maintaining or adding tags unless you go through the API.

Closes: #2741

Solution

Update DatasetTags to include a split button menu and a new dialog/reducer for adding new tags.

Screenshot 2024-03-01 at 10 36 16 Screenshot 2024-03-01 at 10 37 56 Screenshot 2024-03-01 at 10 38 09

One-line summary:

Add Tag dialog box

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Feb 29, 2024
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit c2a9c7c
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/65e75a7d40a177000812f62d

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (a515c91) to head (cb4a1e3).
Report is 153 commits behind head on main.

❗ Current head cb4a1e3 differs from pull request most recent head c2a9c7c. Consider uploading reports for the commit c2a9c7c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2759      +/-   ##
============================================
+ Coverage     83.15%   84.45%   +1.30%     
- Complexity     1286     1416     +130     
============================================
  Files           244      251       +7     
  Lines          5942     6447     +505     
  Branches        282      291       +9     
============================================
+ Hits           4941     5445     +504     
+ Misses          854      850       -4     
- Partials        147      152       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, Can you include a screenshot or video of the behavior for users to see the experience?

web/src/components/datasets/DatasetTags.tsx Outdated Show resolved Hide resolved
web/src/components/datasets/DatasetTags.tsx Outdated Show resolved Hide resolved
web/src/store/reducers/tags.ts Outdated Show resolved Hide resolved
@davidsharp7 davidsharp7 marked this pull request as ready for review March 1, 2024 20:17
@davidsharp7 davidsharp7 changed the title Update dataset tags to allow addition of new tags Update dataset tags to allow editing/addition of tags Mar 1, 2024
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@phixMe phixMe enabled auto-merge (squash) March 5, 2024 17:46
@phixMe phixMe merged commit dde3e28 into MarquezProject:main Mar 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to add new tags
3 participants