-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job tagging to API #2774
Merged
Merged
Add job tagging to API #2774
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0d44966
add job tagging to API
davidsharp7 d114c3f
fix various tests that were failing
davidsharp7 fd76893
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 655bf3a
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 02e7484
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 58f40cf
Merge branch 'main' into api/add_job_tags
davidsharp7 1d3f819
fix merge commit
davidsharp7 057bf14
fix liniting
davidsharp7 4d1550a
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 da04b41
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 3f429f9
Merge branch 'main' into api/add_job_tags
davidsharp7 911549b
update based on pr feedback
davidsharp7 2750d66
Merge branch 'api/add_job_tags' of https://github.com/davidsharp7/mar…
davidsharp7 2b8ae9a
lint tag test code
davidsharp7 b73c6b3
lint tag code
davidsharp7 ca332d6
fix log typo
davidsharp7 322ed34
fix logging
davidsharp7 d127354
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 a64c2f6
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 4517062
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 f726170
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 4065cb5
Merge branch 'MarquezProject:main' into api/add_job_tags
davidsharp7 4c18168
update based on PR feedback.
davidsharp7 10703c1
correct db field error
davidsharp7 bf6621e
Merge branch 'main' into api/add_job_tags
wslulciuc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
api/src/main/resources/marquez/db/migration/V68__add_jobs_tag_mapping.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* SPDX-License-Identifier: Apache-2.0 */ | ||
CREATE TABLE jobs_tag_mapping ( | ||
job_uuid UUID REFERENCES jobs(uuid), | ||
tag_uuid UUID REFERENCES tags(uuid), | ||
tagged_at TIMESTAMP NOT NULL, | ||
wslulciuc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
PRIMARY KEY (tag_uuid, job_uuid) | ||
); | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be quite unlikely given
updateJobTags
would presumably throw if the job didn't exist? A case of, we get an optional back so we should do something beyond an unqualifiedget()
on it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah understand what you mean -it will fall over before it gets to this point so why bother? Mainly as that seems to be the de-facto pattern for a lot of the code i.e
execute something -> retrieve object (job, dataset etc) else throw an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following our code style!