-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization of Apache HTTP in Java client #2822
Merged
wslulciuc
merged 2 commits into
MarquezProject:main
from
davidjgoss:feature/java-client-customise-http-client
May 30, 2024
Merged
Allow customization of Apache HTTP in Java client #2822
wslulciuc
merged 2 commits into
MarquezProject:main
from
davidjgoss:feature/java-client-customise-http-client
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
=========================================
Coverage 84.55% 84.56%
- Complexity 1440 1441 +1
=========================================
Files 251 251
Lines 6501 6504 +3
Branches 302 303 +1
=========================================
+ Hits 5497 5500 +3
Misses 851 851
Partials 153 153 ☔ View full report in Codecov by Sentry. |
davidjgoss
force-pushed
the
feature/java-client-customise-http-client
branch
from
May 25, 2024 09:09
0380956
to
d52ba48
Compare
davidjgoss
changed the title
Allow custom connection manager in Java client
Allow customisation of apache http in Java client
May 25, 2024
davidjgoss
changed the title
Allow customisation of apache http in Java client
Allow customisation of Apache HTTP in Java client
May 25, 2024
wslulciuc
reviewed
May 29, 2024
davidjgoss
force-pushed
the
feature/java-client-customise-http-client
branch
from
May 29, 2024 18:25
d52ba48
to
89d39f7
Compare
davidjgoss
changed the title
Allow customisation of Apache HTTP in Java client
Allow customization of Apache HTTP in Java client
May 29, 2024
Signed-off-by: David Goss <[email protected]>
davidjgoss
force-pushed
the
feature/java-client-customise-http-client
branch
from
May 29, 2024 21:48
89d39f7
to
c2493f0
Compare
wslulciuc
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MarquezClient
uses the Apache HTTP client under the hood, and its defaults have some limitations around e.g. connection management. I'd like to be able to customize the client to my needs.Solution
Add a builder method so you can provide a
Consumer<HttpClientBuilder>
allowing full customization of the Apache client without replicating its entire API on the Marquez side.One-line summary: Allow customization of Apache HTTP in Java client
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)