Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing no runs list rendering. #2935

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fixing no runs list rendering. #2935

merged 1 commit into from
Oct 18, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Oct 18, 2024

Problem

image

This pull request includes a small but important change to the JobRunItem component in the web/src/routes/dashboard/JobRunItem.tsx file. The change corrects the logic used to calculate the length of the array for displaying the last 10 job runs.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit af700a2
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6712cf2040cdac0008080faa

@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 18, 2024
@wslulciuc wslulciuc enabled auto-merge (squash) October 18, 2024 21:13
@wslulciuc wslulciuc merged commit d9ec368 into main Oct 18, 2024
15 checks passed
@wslulciuc wslulciuc deleted the fix/no-runs-handling branch October 18, 2024 21:20
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (7cf1f6a) to head (af700a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2935   +/-   ##
=========================================
  Coverage     81.12%   81.12%           
  Complexity     1506     1506           
=========================================
  Files           268      268           
  Lines          7365     7365           
  Branches        329      329           
=========================================
  Hits           5975     5975           
  Misses         1229     1229           
  Partials        161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants