Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Better handling of missing environment variables in setupProxy.js file #2956

Merged

Conversation

arturowczarek
Copy link
Contributor

Problem

At some point (August 2024) setupProxy.js started using WEB_PORT. The related docker compose configuration files not always have it updated. Without this variable set, the containers start but listen on undefined port. The users can't use the stack and are confused why. Here's an example of a fix of this king of problem OpenLineage/OpenLineage#3192

Solution

When some important environment variable is missing the application should stop and the user should stay informed about that they should do next.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Oct 28, 2024
Copy link

boring-cyborg bot commented Oct 28, 2024

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit d051529
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/671f7a733094ad00085564d1

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (9e2e9b4) to head (d051529).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2956   +/-   ##
=========================================
  Coverage     81.19%   81.19%           
  Complexity     1505     1505           
=========================================
  Files           268      268           
  Lines          7358     7358           
  Branches        325      325           
=========================================
  Hits           5974     5974           
  Misses         1226     1226           
  Partials        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @arturowczarek! 💯 💯 🥇

@phixMe phixMe merged commit 2d163ce into MarquezProject:main Oct 28, 2024
16 checks passed
Copy link

boring-cyborg bot commented Oct 28, 2024

Great job! Congrats on your first merged pull request in the Marquez project!

lmassaoy pushed a commit to nubank/NuMarquez that referenced this pull request Oct 28, 2024
* Fixing data quality display. (MarquezProject#2937)

Signed-off-by: phixMe <[email protected]>

* Dataset Version call simplification (MarquezProject#2938)

* Fixing data quality display.

Signed-off-by: phixMe <[email protected]>

* Fixing dataset version calls.

Signed-off-by: phixMe <[email protected]>

---------

Signed-off-by: phixMe <[email protected]>

* feat: allow db-migrate without version (MarquezProject#2936)

Signed-off-by: David Goss <[email protected]>

* Display full `runID` and check icon when copied (MarquezProject#2940)

Signed-off-by: Willy Lulciuc <[email protected]>

* Deferred copy revert. (MarquezProject#2941)

Signed-off-by: phixMe <[email protected]>

* Long text handling (MarquezProject#2942)

* Deferred copy revert.

Signed-off-by: phixMe <[email protected]>

* Long text handling.

Signed-off-by: phixMe <[email protected]>

* Adding search back in.

Signed-off-by: phixMe <[email protected]>

---------

Signed-off-by: phixMe <[email protected]>

* Use project root for docker volume prefix (MarquezProject#2943)

Signed-off-by: Willy Lulciuc <[email protected]>

* fix: Correct SQL query pagination for DatasetVersion findAll method (MarquezProject#2945)

Signed-off-by: Alper İnan <[email protected]>
Signed-off-by: Alper <[email protected]>

* Update changelog for `0.50.0`

Signed-off-by: Willy Lulciuc <[email protected]>

* Replace `redoc-cli` with `redocly`

Signed-off-by: Willy Lulciuc <[email protected]>

* Prepare for release 0.50.0

Signed-off-by: Willy Lulciuc <[email protected]>

* Prepare next development version 0.51.0-SNAPSHOT

Signed-off-by: Willy Lulciuc <[email protected]>

* Templatize event time in `metadata.json` (MarquezProject#2946)

* Templatize event time in `metadata.json`

Signed-off-by: Willy Lulciuc <[email protected]>

* Use `metadata.template.json`

Signed-off-by: Willy Lulciuc <[email protected]>

---------

Signed-off-by: Willy Lulciuc <[email protected]>

* Update CHANGELOG.md

* Update `web/docs/demo.gif` (MarquezProject#2948)

Signed-off-by: Willy Lulciuc <[email protected]>

* fix(deps): update dependency io.openlineage:openlineage-java to v1.23.0 (MarquezProject#2907)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency org.assertj:assertj-core to v3.26.3 (MarquezProject#2909)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Willy Lulciuc <[email protected]>

* fix(deps): update dependency org.postgresql:postgresql to v42.7.4 (MarquezProject#2912)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency org.opensearch.client:opensearch-rest-client to v2.17.1 (MarquezProject#2911)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Willy Lulciuc <[email protected]>

* fix(deps): update dependency org.apache.commons:commons-lang3 to v3.17.0 (MarquezProject#2908)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Ignore `**/stats/**` (MarquezProject#2952)

Signed-off-by: Willy Lulciuc <[email protected]>

* Update compatibility for `0.50.0`

* fix(deps): update dependency org.opensearch.client:opensearch-java to v2.16.0 (MarquezProject#2910)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* `Dataset.currentVersionUuid` `->` `DatasetVersion.uuid` (MarquezProject#2954)

Signed-off-by: Willy Lulciuc <[email protected]>

* Update Events Page (MarquezProject#2955)

* Tuning the events page for longer events.

Signed-off-by: phixMe <[email protected]>

* Adding events file.

Signed-off-by: phixMe <[email protected]>

* Refetch jobs button.

Signed-off-by: phixMe <[email protected]>

* Refetch jobs button.

Signed-off-by: phixMe <[email protected]>

* Lint

Signed-off-by: phixMe <[email protected]>

---------

Signed-off-by: phixMe <[email protected]>
Co-authored-by: Willy Lulciuc <[email protected]>

* Lineage run attachment issue. (MarquezProject#2953)

Signed-off-by: phixMe <[email protected]>
Co-authored-by: Willy Lulciuc <[email protected]>

* feature: Better handling of missing environment variables in setupProxy.js file. (MarquezProject#2956)

Signed-off-by: Artur Owczarek <[email protected]>

---------

Signed-off-by: phixMe <[email protected]>
Signed-off-by: David Goss <[email protected]>
Signed-off-by: Willy Lulciuc <[email protected]>
Signed-off-by: Alper İnan <[email protected]>
Signed-off-by: Alper <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Artur Owczarek <[email protected]>
Co-authored-by: Peter Hicks <[email protected]>
Co-authored-by: davidjgoss <[email protected]>
Co-authored-by: Willy Lulciuc <[email protected]>
Co-authored-by: Alper İnan <[email protected]>
Co-authored-by: Willy Lulciuc <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Artur Owczarek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants