Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock rust toolchain on v1.76.0 because higher versions segfaults during PGO gather #46

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

MarshalX
Copy link
Owner

@MarshalX MarshalX commented Sep 7, 2024

I don't have time to debug this shit. It just segfaults with higher rust toolchain on gha runners

refs:

and reported bug to rust repository (without repro). i will not link to to not bind issues between

Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #46 will degrade performances by 26.66%

Comparing lock-rust-1.76.0 (d8e4386) with main (04ba564)

Summary

⚡ 4 improvements
❌ 4 regressions
✅ 184 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main lock-rust-1.76.0 Change
test_dag_cbor_decode[roundtrip05.json] 19.4 µs 25.2 µs -23.14%
test_dag_cbor_decode[roundtrip25.json] 24 µs 18.7 µs +28.34%
test_dag_cbor_encode[roundtrip04.json] 22.9 µs 17 µs +34.26%
test_dag_cbor_encode[roundtrip08.json] 17 µs 23.2 µs -26.66%
test_dag_cbor_encode[roundtrip09.json] 27 µs 21.3 µs +27.08%
test_dag_cbor_encode[roundtrip13.json] 23.1 µs 17.7 µs +30.26%
test_dag_cbor_encode[roundtrip17.json] 17.2 µs 23.1 µs -25.37%
test_dag_cbor_encode[roundtrip25.json] 16.9 µs 22.9 µs -26.08%

@MarshalX MarshalX merged commit 7ad062a into main Sep 7, 2024
2 of 3 checks passed
@MarshalX MarshalX deleted the lock-rust-1.76.0 branch September 7, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant