Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-ui): post and reaction notification links #317

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

johnmasking
Copy link
Member

Fixes #311

Changes proposed in this pull request:

  • Make rated Comic or rated Comment clickable
  • make a new route to display reaction details
  • new feature to display Reaction details

@MaskingTechnology/comify

@johnmasking johnmasking linked an issue Aug 16, 2024 that may be closed by this pull request
@petermasking petermasking changed the title feat(web-ui) post and reaction notification links feat(web-ui): post and reaction notification links Aug 16, 2024
@@ -16,21 +16,22 @@ type Props = {
readonly notification: NotificationView;
readonly onFollowClick: (relation: RelationView) => Promise<void>;
readonly onCreatorClick: (relation: RelationView) => void;
readonly onReactionClick: (reaction: ReactionView) => void;
readonly onComicClick: (post: PostView) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readonly onComicClick: (post: PostView) => void;
readonly onPostClick: (post: PostView) => void;

Comment on lines 13 to 14

return <Column alignX='stretch' alignY='justify' gap='medium'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return <Column alignX='stretch' alignY='justify' gap='medium'>
return <Column alignX='stretch' alignY='justify' gap='medium'>

Comment on lines 69 to 74
<Row alignY='stretch' alignX='justify' >
<Text value='single reaction' />
<ClickArea onClick={() => viewPost(post as PostView)}>
<Text value='all reactions' />
</ClickArea>
</Row>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make this a separate component.


}, [reactions, setReactions]);
}, [navigate, identity]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The identity dependency can be removed.

Comment on lines 9 to 10
import { Column, Ruler } from '../designsystem';
import useEstablishRelation from './hooks/useEstablishRelation';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Column, Ruler } from '../designsystem';
import useEstablishRelation from './hooks/useEstablishRelation';
import { Column, Ruler } from '../designsystem';
import useEstablishRelation from './hooks/useEstablishRelation';

Missing enter between the external and local imports.

import { ClickArea, Row, Text } from '^/webui/designsystem';

type Props = {
readonly onPostClick: () => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readonly onPostClick: () => void;
readonly onShowAllClick: () => void;

Copy link

sonarcloud bot commented Aug 20, 2024

@petermasking petermasking merged commit 7800974 into main Aug 20, 2024
5 checks passed
@petermasking petermasking deleted the 311-post-and-reaction-notification-links branch August 20, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post and reaction notification links
2 participants