feat(web-ui): post and reaction notification links #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermasking
changed the title
petermasking
requested changes
Aug 19, 2024
| @@ -16,21 +16,22 @@ type Props = { | |||
| readonly notification: NotificationView; | |||
| readonly onFollowClick: (relation: RelationView) => Promise<void>; | |||
| readonly onCreatorClick: (relation: RelationView) => void; | |||
| readonly onReactionClick: (reaction: ReactionView) => void; | |||
| readonly onComicClick: (post: PostView) => void; | |||
There was a problem hiding this comment.
Suggested change
| readonly onComicClick: (post: PostView) => void; | |
| readonly onPostClick: (post: PostView) => void; |
Comment on lines
13
to
14
|
|
||
| return <Column alignX='stretch' alignY='justify' gap='medium'> |
There was a problem hiding this comment.
Suggested change
| return <Column alignX='stretch' alignY='justify' gap='medium'> | |
| return <Column alignX='stretch' alignY='justify' gap='medium'> |
Comment on lines
69
to
74
| <Row alignY='stretch' alignX='justify' > | ||
| <Text value='single reaction' /> | ||
| <ClickArea onClick={() => viewPost(post as PostView)}> | ||
| <Text value='all reactions' /> | ||
| </ClickArea> | ||
| </Row> |
There was a problem hiding this comment.
I think we can make this a separate component.
|
|
||
| }, [reactions, setReactions]); | ||
| }, [navigate, identity]); |
There was a problem hiding this comment.
The identity dependency can be removed.
petermasking
requested changes
Aug 20, 2024
Comment on lines
9
to
10
| import { Column, Ruler } from '../designsystem'; | ||
| import useEstablishRelation from './hooks/useEstablishRelation'; |
There was a problem hiding this comment.
Suggested change
| import { Column, Ruler } from '../designsystem'; | |
| import useEstablishRelation from './hooks/useEstablishRelation'; | |
| import { Column, Ruler } from '../designsystem'; | |
| import useEstablishRelation from './hooks/useEstablishRelation'; |
Missing enter between the external and local imports.
| import { ClickArea, Row, Text } from '^/webui/designsystem'; | ||
|
|
||
| type Props = { | ||
| readonly onPostClick: () => void; |
There was a problem hiding this comment.
Suggested change
| readonly onPostClick: () => void; | |
| readonly onShowAllClick: () => void; |
|
petermasking
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311
Changes proposed in this pull request:
@MaskingTechnology/comify