Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reflection): dynamic import support #199

Merged

Conversation

petermasking
Copy link
Member

Fixes #198

Changes proposed in this pull request:

  • Added support for dynamic imports

@MaskingTechnology/jitar

@petermasking petermasking linked an issue Mar 8, 2023 that may be closed by this pull request
@@ -278,6 +278,16 @@ export default class Parser
{
return new ReflectionImport(members, token.value);
}
else if (token.hasValue(Group.OPEN))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically the same exception as the import above (without members), so it I found it logical to group them.

@basmasking basmasking merged commit c043013 into main Mar 8, 2023
@basmasking basmasking deleted the 198-add-support-for-dynamic-imports-to-the-reflection branch March 8, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for dynamic imports to the reflection
2 participants