feat(server): removed experimental decorators #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermasking
requested changes
Apr 19, 2023
| import { IsBoolean } from 'class-validator'; | ||
| import { z } from 'zod'; | ||
|
|
||
| export const schema = z.object({ |
There was a problem hiding this comment.
.object (and others) should start at a new line
There was a problem hiding this comment.
Removed the whole object. It was not used
| import { ArrayNotEmpty, IsUrl } from 'class-validator'; | ||
| import { z } from 'zod'; | ||
|
|
||
| export const schema = z.object({ |
There was a problem hiding this comment.
.object (and others) should start at a new line
| import StandaloneConfiguration from './StandaloneConfiguration.js'; | ||
| import { z } from 'zod'; | ||
|
|
||
| import GatewayConfiguration, { schema as gatewaySchema } from './GatewayConfiguration.js'; |
There was a problem hiding this comment.
Should we rename the exports of the schemas to avoid renaming them in the import?
| @@ -1,19 +1,17 @@ | |||
|
|
|||
| import { readFileSync } from 'fs'; | |||
|
|
|||
| import RuntimeConfiguration from '../configuration/RuntimeConfiguration.js'; | |||
| import RuntimeConfiguration, { schema as RuntimeSchema } from '../configuration/RuntimeConfiguration.js'; | |||
There was a problem hiding this comment.
runtimeSchema (starting with a lower case)
petermasking
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
Changes proposed in this pull request:
@MaskingTechnology/jitar