-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): removed experimental decorators #259
feat(server): removed experimental decorators #259
Conversation
import { IsBoolean } from 'class-validator'; | ||
import { z } from 'zod'; | ||
|
||
export const schema = z.object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.object (and others) should start at a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the whole object. It was not used
import { ArrayNotEmpty, IsUrl } from 'class-validator'; | ||
import { z } from 'zod'; | ||
|
||
export const schema = z.object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.object (and others) should start at a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
import StandaloneConfiguration from './StandaloneConfiguration.js'; | ||
import { z } from 'zod'; | ||
|
||
import GatewayConfiguration, { schema as gatewaySchema } from './GatewayConfiguration.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename the exports of the schemas to avoid renaming them in the import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Processed
@@ -1,19 +1,17 @@ | |||
|
|||
import { readFileSync } from 'fs'; | |||
|
|||
import RuntimeConfiguration from '../configuration/RuntimeConfiguration.js'; | |||
import RuntimeConfiguration, { schema as RuntimeSchema } from '../configuration/RuntimeConfiguration.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runtimeSchema
(starting with a lower case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fixes #253
Changes proposed in this pull request:
@MaskingTechnology/jitar