chore(packaging): configure rollup for jitar #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermasking
requested changes
Apr 24, 2023
.eslintrc.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "root": true, | |||
| "ignorePatterns": ["**/dist/**/*", "**/node_modules/**/*","**/coverage/**/*", "**/*config*", "packages/create-jitar/templates/*"], | |||
| "ignorePatterns": ["**/lib/**/*", "**/dist/**/*", "**/node_modules/**/*","**/coverage/**/*", "**/*config*", "packages/create-jitar/templates/*"], | |||
There was a problem hiding this comment.
Die we still need to igore the lib folder?
package.json
Outdated
| @@ -34,6 +34,11 @@ | |||
| "test": "npm run test --workspace=packages/reflection --workspace=packages/serialization --workspace=packages/runtime --workspace=packages/caching --workspace=packages/server-nodejs --workspace=packages/jitar --workspace=packages/create-jitar --workspace=packages/plugin-vite --if-present" | |||
| }, | |||
| "devDependencies": { | |||
| "@rollup/plugin-json": "^6.0.0", | |||
There was a problem hiding this comment.
This plugin seems to be unused
packages/.gitignore
Outdated
| dist | ||
| lib |
There was a problem hiding this comment.
Do we still need this lib?
packages/.gitignore
Outdated
| @@ -1,5 +1,7 @@ | |||
| coverage | |||
| build | |||
There was a problem hiding this comment.
Do we still need this build?
There was a problem hiding this comment.
Not at the moment. We can add it if required later.
packages/jitar/tsconfig.json
Outdated
| "target": "ESNext", | ||
| "module": "ESNext", | ||
| "declaration": true, | ||
| "declarationDir": "./dist/types", |
There was a problem hiding this comment.
This line seems to have tabs instead of spaces.
packages/runtime/package.json
Outdated
| @@ -18,7 +18,8 @@ | |||
| "release": "npm run clean && npm run build && npm publish" | |||
| }, | |||
| "dependencies": { | |||
| "@jitar/serialization": "^0.4.0" | |||
| "@jitar/serialization": "^0.4.0", | |||
| "@jitar/errors": "^0.4.0" | |||
packages/server-nodejs/package.json
Outdated
| @@ -20,11 +20,10 @@ | |||
| "dependencies": { | |||
| "@jitar/caching": "^0.4.0", | |||
| "@jitar/runtime": "^0.4.0", | |||
| "class-transformer": "^0.5.1", | |||
| "class-validator": "^0.14.0", | |||
| "@jitar/errors": "^0.4.0", | |||
There was a problem hiding this comment.
I made quite a mess of cleaning up ...
petermasking
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
Changes proposed in this pull request:
@MaskingTechnology/jitar