Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packaging): configure rollup for jitar #261

Merged
merged 22 commits into from
Apr 24, 2023

Conversation

basmasking
Copy link
Member

Fixes #249

Changes proposed in this pull request:

  • Added rollup configuration to bundle jitar in servable packages
  • Use the name field for type checking in reflection
  • Reroute the external jitar dependencies to the internal jitar dependencies

@MaskingTechnology/jitar

@basmasking basmasking linked an issue Apr 24, 2023 that may be closed by this pull request
Copy link
Member

@petermasking petermasking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Needs a last cleanup round.

.eslintrc.json Outdated
@@ -1,6 +1,6 @@
{
"root": true,
"ignorePatterns": ["**/dist/**/*", "**/node_modules/**/*","**/coverage/**/*", "**/*config*", "packages/create-jitar/templates/*"],
"ignorePatterns": ["**/lib/**/*", "**/dist/**/*", "**/node_modules/**/*","**/coverage/**/*", "**/*config*", "packages/create-jitar/templates/*"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die we still need to igore the lib folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we don't

package.json Outdated
@@ -34,6 +34,11 @@
"test": "npm run test --workspace=packages/reflection --workspace=packages/serialization --workspace=packages/runtime --workspace=packages/caching --workspace=packages/server-nodejs --workspace=packages/jitar --workspace=packages/create-jitar --workspace=packages/plugin-vite --if-present"
},
"devDependencies": {
"@rollup/plugin-json": "^6.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin seems to be unused

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, removed

dist
lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this lib?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, also removed

@@ -1,5 +1,7 @@
coverage
build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at the moment. We can add it if required later.

"target": "ESNext",
"module": "ESNext",
"declaration": true,
"declarationDir": "./dist/types",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems to have tabs instead of spaces.

@@ -18,7 +18,8 @@
"release": "npm run clean && npm run build && npm publish"
},
"dependencies": {
"@jitar/serialization": "^0.4.0"
"@jitar/serialization": "^0.4.0",
"@jitar/errors": "^0.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgotten

@@ -20,11 +20,10 @@
"dependencies": {
"@jitar/caching": "^0.4.0",
"@jitar/runtime": "^0.4.0",
"class-transformer": "^0.5.1",
"class-validator": "^0.14.0",
"@jitar/errors": "^0.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Th errors can be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made quite a mess of cleaning up ...

@petermasking petermasking merged commit d5238cc into main Apr 24, 2023
@petermasking petermasking deleted the 249-configure-rollup-for-jitar branch April 24, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure rollup for jitar
2 participants