237 middleware per procedure #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd response information.
basmasking
requested changes
Dec 5, 2023
| { | ||
| const result = await this.#runner.run(fqn, version, args, headers); | ||
| const result = await this.#runner.run(request); |
There was a problem hiding this comment.
I would expect the name of the variable to be called response.
|
|
||
| headers.clear(); | ||
| request.clearHeaders(); |
There was a problem hiding this comment.
Why are you clearing the request headers. We had to clear the headers in the previous setup where we reused the headers map for the response as well, but we do have a separate response object here.
|
|
||
| get headers() { return this.#headers; } | ||
|
|
||
| clearHeaders() |
| this.#headers.clear(); | ||
| } | ||
|
|
||
| setHeader(name: string, value: string) |
| return this.#headers.get(name); | ||
| } | ||
|
|
||
| removeHeader(name: string) |
| return this.#args.get(name); | ||
| } | ||
|
|
||
| removeArgument(name: string) |
|
|
||
| get headers() { return this.#headers; } | ||
|
|
||
| setArgument(name: string, value: unknown) |
basmasking
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
Changes proposed in this pull request:
@MaskingTechnology/jitar