Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MPGS not supporting float #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jflaflamme
Copy link

Prevents an error from MPGS regarding the order total field length.

@chirag-ontap
Copy link

Prevents an error from MPGS regarding the order total field length.

@jflaflamme Thank you for creating PR.

However, can you please provide the exact steps to reproduce it?
Along with your Wordpress, WooCommerce and MPGS Module version details?

@kimkinak
Copy link

Prevents an error from MPGS regarding the order total field length.

@jflaflamme Thank you for creating PR.

However, can you please provide the exact steps to reproduce it? Along with your Wordpress, WooCommerce and MPGS Module version details?

@chirag-ontap Thanks for your participate.

We did fresh installed WordPress and WooCommerce and tested. We still got error.
Our detail below:
=>WordPress version : 6.0.1
=>WooCommerce version: 6.8.0
=>MPGS version: 1.3.0

Instruction of Purchasing

  1. Go to Shop > Add Product with Price= 40.00$ (without decimal point)> Checkout > Place Order > Fill Card Info > Pay > Order Successes.
  2. Go to Shop > Add Product with Price= 39.99$ (with decimal point)> Checkout > Place Order > Error Floating Message as below:

<<!! Error: {"readyState":4,"responseText":"{"code":"internal_server_error","message":"

There has been a critical error on this website.<\/p>

<a href=\"https:\/\/wordpress.org\/support\/article\/faq-troubleshooting\/\">Learn more about troubleshooting WordPress.<\/a><\/p>","data":{"status":500},"additional_errors":[]}","responseJSON":{"code":"internal_server_error","message":"

There has been a critical error on this website.

<a href="https://wordpress.org/support/article/faq-troubleshooting/\">Learn more about troubleshooting WordPress.

","data":{"status":500},"additional_errors":[]},"status":500,"statusText":"error"} !!>>

error floating

@harshitshah20
Copy link

Hello,

We have checked and recommend applying this code change as it goes against the logic of the WooCommerce platform. The plugin uses the following method to retrieve the value, and it has to be properly formatted:

https://hooks.wbcomdesigns.com/reference/classes/wc_abstract_order/get_total/

Also, we have checked and the module work itself so the issue seems to be related to some other problem. It seems like the issue is specific to your environment.

Let us know if you are still experiencing the issue and if yes, then provide email address on which I can raise a support ticket to help you further.

@chirag-ontap
Copy link

@kimkinak Do you have any update on below? Are you still facing issue?

==> Hello,
==> We have checked and recommend applying this code change as it goes against the logic of the WooCommerce platform. The plugin uses the following method to retrieve the value, and it has to be properly formatted:

==> https://hooks.wbcomdesigns.com/reference/classes/wc_abstract_order/get_total/

==> Also, we have checked and the module work itself so the issue seems to be related to some other problem. It seems like the issue is specific to your environment.

==> Let us know if you are still experiencing the issue and if yes, then provide email address on which I can raise a support ticket to help you further.

@Yan-Aleman
Copy link

Hello. Will there be a plugin update? When installing the plugin, a fatal error appears. I have the latest version of WooCommerce and WordPress.

@westerandr
Copy link

Hi there, I have the latest versions of wordpress, woocommerce & MPGS. However when I create orders, the order id/number is different on wordpress/woocommerce and than the one sent to MPGS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants