-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for destroy_data and update_data to be sent #182
Conversation
It would be awesome to have the same feature for update and delete. |
@m-garrido @melt-melt |
@DRuggeri I needed to update the GH release action also following this comment hashicorp/ghaction-import-gpg#11 (comment) I can remove the commit before merging. |
@m-garrido @melt-melt Update: This PR is already merged, please use the official version >= 1.18.0! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the update_data changes in an actual project and can confirm that it works fine.
Refer to [https://github.com//issues/190]
@DRuggeri can you help me here to get that merged? If something is missing like tests or docs, just tell me. Thanks in advance 🙏 |
@douernesto @Martina-May |
Hello, I am also waiting for this feature. Would be nice to have it released soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, though I am concerned about some of the changes to the release workflow. Can you please address those?
Many apologies for the delay responding to this PR. This seems to make a lot of sense and I've added a quick few notes. If you can address those, we can go ahead and merge and cut a new release with this! |
@DRuggeri Thanks for the feedback. I addressed it. |
This PR is inspired by #177 and it adds one feature:
It could solve #174 I think.