fix #257 Adding option to set the obj id from a non JSON response #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 9, 2024 21:06
… we can identify we are not getting a formatted JSON response object If we get a response as a string or int we are assigning that response as the id of the obj. We need to set the `id_attribute` to `*`
* Adding a Makefile for simplicity to build the project and clean it, also to run the tests more easily * Updated the fakeserver so we can test the new func for non JSON responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing the #257 issue. If an API response with a non JSON formatted obj (a string or int i.e
1234ormy-string) we are going to use that value as the tf obj id. We need to set theid_attributeoption as*.Example
Example non-JSON response from the fakeserver:
curl 127.0.0.1:8080/api/objects -X POST -d '{ "Id": "1", "Name": "Foo", "No_json": true}' 1That
1will be used as the Obj IDTests
Under
restapi/api_object_test.gocreated thecreate_object_no_json_responsetest case