Retry on errors with specified HTTP methods #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @nvelat! I know this was created in reference to #34 which was just fixed (creating the merge conflict), but I see the community desire for retry logic aside from that issue. Can you share a few scenarios in this PR that retry logic would be helpful? A quick thought is that if we are going to go as far as enabling retry logic, we should also let the user configure a cooldown timer and decide which status codes should be retried as well. Just hoping to get the reasonably expected scenarios covered... |
|
This looks excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes PR: #36
Issue: #34
Allow the user to specify a list of HTTP methods to retry requests on if a status code in the range [500, 600] is received.