feat: nil version equality #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Equal method to return true for 2 nil values and false if any one of the values is nil. Previously passing a nil value would have resulted in a panic.
|
Just adding another comment in favor of this PR! I just ran into a panic when calling equal on a nil version. It would be great if this case was handled! |
mattfarina
approved these changes
May 14, 2024
There was a problem hiding this comment.
This flow makes sense. It's a minor optimization for some cases and it stops a panic from happening in some other places.
Note:
a := MustParse("1.2.3")
b := MustParse("1.2.3")
// a != bTo get equality with == you need...
a := MustParse("1.2.3")
b := a
// a == b
|
@mattfarina is it possible to cut a release with this? |
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go
Aug 28, 2024
…5750) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/Masterminds/semver/v3](https://togithub.com/Masterminds/semver) | `v3.2.1` -> `v3.3.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Masterminds/semver (github.com/Masterminds/semver/v3)</summary> ### [`v3.3.0`](https://togithub.com/Masterminds/semver/releases/tag/v3.3.0) [Compare Source](https://togithub.com/Masterminds/semver/compare/v3.2.1...v3.3.0) #### What's Changed - Fix: bad package in README by [@​sdelicata](https://togithub.com/sdelicata) in [https://github.com/Masterminds/semver/pull/226](https://togithub.com/Masterminds/semver/pull/226) - Updating the GitHub Actions and versions of Go used by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/229](https://togithub.com/Masterminds/semver/pull/229) - Fix spelling in README by [@​robinschneider](https://togithub.com/robinschneider) in [https://github.com/Masterminds/semver/pull/222](https://togithub.com/Masterminds/semver/pull/222) - Adding go build cache to fuzz output by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/232](https://togithub.com/Masterminds/semver/pull/232) - Add caching to fuzz testing by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/234](https://togithub.com/Masterminds/semver/pull/234) - updating github actions by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/235](https://togithub.com/Masterminds/semver/pull/235) - feat: nil version equality by [@​KnutZuidema](https://togithub.com/KnutZuidema) in [https://github.com/Masterminds/semver/pull/213](https://togithub.com/Masterminds/semver/pull/213) - add >= and <= by [@​grosser](https://togithub.com/grosser) in [https://github.com/Masterminds/semver/pull/238](https://togithub.com/Masterminds/semver/pull/238) - doc: hyphen range constraint without whitespace by [@​johnnychen94](https://togithub.com/johnnychen94) in [https://github.com/Masterminds/semver/pull/216](https://togithub.com/Masterminds/semver/pull/216) - Removing reference to vert by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/245](https://togithub.com/Masterminds/semver/pull/245) - simplify StrictNewVersion by [@​grosser](https://togithub.com/grosser) in [https://github.com/Masterminds/semver/pull/241](https://togithub.com/Masterminds/semver/pull/241) - Updating the testing version of Go used by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/246](https://togithub.com/Masterminds/semver/pull/246) - bumping min version in go.mod based on what's tested by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/248](https://togithub.com/Masterminds/semver/pull/248) - Updating changelog for 3.3.0 by [@​mattfarina](https://togithub.com/mattfarina) in [https://github.com/Masterminds/semver/pull/249](https://togithub.com/Masterminds/semver/pull/249) #### New Contributors - [@​sdelicata](https://togithub.com/sdelicata) made their first contribution in [https://github.com/Masterminds/semver/pull/226](https://togithub.com/Masterminds/semver/pull/226) - [@​robinschneider](https://togithub.com/robinschneider) made their first contribution in [https://github.com/Masterminds/semver/pull/222](https://togithub.com/Masterminds/semver/pull/222) - [@​KnutZuidema](https://togithub.com/KnutZuidema) made their first contribution in [https://github.com/Masterminds/semver/pull/213](https://togithub.com/Masterminds/semver/pull/213) - [@​grosser](https://togithub.com/grosser) made their first contribution in [https://github.com/Masterminds/semver/pull/238](https://togithub.com/Masterminds/semver/pull/238) - [@​johnnychen94](https://togithub.com/johnnychen94) made their first contribution in [https://github.com/Masterminds/semver/pull/216](https://togithub.com/Masterminds/semver/pull/216) **Full Changelog**: Masterminds/semver@v3.2.1...v3.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Equal method to return true for 2 nil values and false if any one of the values is nil. Previously passing a nil value would have resulted in a panic.