Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window functions: Reduce - FlatMap UnnestList fusion #29554

Merged
merged 5 commits into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    cecaded View commit details
    Browse the repository at this point in the history
  2. compute: Further preparations for Reduce-FlatMap fusion

    - Factors out Reduce lowering into a separate fn.
    - Some code motion in FlatMap lowering. Checking the preconditions
      for fusion will be a multi-step process, from which we'll to bail
      out to the standard FlatMap lowering at multiple stages.
    ggevay committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3b60ded View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e24b28 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dab35b1 View commit details
    Browse the repository at this point in the history
  5. Reduce-FlatMap fusion: address Moritz's comments + minor things

    In addition to addressing the comments, this:
    - adds more tests
    - flips the feature flag's default to true, and addresses the test
      fallout.
    - adds a soft_assert_or_log for missing a fusion due to the complex
      pattern match failing.
    ggevay committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    33f63b5 View commit details
    Browse the repository at this point in the history