alter_table: Support adding columns to tables #29694
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changes Table to have a VersionedRelationDesc * updates Catalog APIs to require specifying a version when getting a RelationDesc * plumb versions around to the necessary spots
* add Catalog Op::AlterAddColumn * implement sequencing
* but when the feature is off existing views still work
ParkMyCar
force-pushed
the
alter_table/support-adding-columns
branch
from
7b138de
to
e55eb31
Compare
|
Tell me when this is ready for testing, there are some tests/frameworks where this will be a good fit (platform-checks, parallel-workload). |
* fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress
Motivation
Fixes: #28082
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.